Skip to content

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 24, 2025

  • Update version placeholders
  • Update stage0 to 1.89.0-beta.1
  • Update STAGE0_MISSING_TARGETS
  • Update cfg(bootstrap)

r? @Mark-Simulacrum

try-job: dist-i586-gnu-i586-i686-musl

@rustbot rustbot added O-android Operating system: Android O-linux Operating system: Linux S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jun 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

The Miri subtree was changed

cc @rust-lang/miri

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

☔ The latest upstream changes (presumably #142979) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 25, 2025

📌 Commit 6cacbc7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2025
@Mark-Simulacrum
Copy link
Member

@bors rollup=iffy

samueltardieu added a commit to samueltardieu/rust that referenced this pull request Jun 26, 2025
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? `@Mark-Simulacrum`
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 27, 2025
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? ``@Mark-Simulacrum``
bors added a commit that referenced this pull request Jun 27, 2025
…rors

Rollup of 8 pull requests

Successful merges:

 - #139858 (New const traits syntax)
 - #140809 (Reduce special casing for the panic runtime)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142974 (Update stage0 to 1.89.0-beta.1)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143002 (tests: Require `run-fail` ui tests to have an exit code (`SIGABRT` not ok))
 - #143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology)
 - #143096 (tag_for_variant: properly pass TypingEnv)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? `@Mark-Simulacrum`
This was referenced Jun 28, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
…crum

Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? ``@Mark-Simulacrum``
bors added a commit that referenced this pull request Jun 28, 2025
Rollup of 10 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142974 (Update stage0 to 1.89.0-beta.1)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr
Copy link
Member

@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 28, 2025
@bors
Copy link
Collaborator

bors commented Jun 29, 2025

📌 Commit 0b1aa27 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2025
bors added a commit that referenced this pull request Jun 30, 2025
Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? `@Mark-Simulacrum`

try-job: dist-i586-gnu-i586-i686-musl
@bors
Copy link
Collaborator

bors commented Jun 30, 2025

⌛ Testing commit 0b1aa27 with merge ef67915...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Jun 30, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 30, 2025
@cuviper
Copy link
Member Author

cuviper commented Jul 1, 2025

Rebased, and removed another new miri bootstrap.

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Jul 1, 2025

📌 Commit 5b073e5 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025
@bors
Copy link
Collaborator

bors commented Jul 2, 2025

⌛ Testing commit 5b073e5 with merge f51c987...

@bors
Copy link
Collaborator

bors commented Jul 2, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f51c987 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 2, 2025
@bors bors merged commit f51c987 into rust-lang:master Jul 2, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 2, 2025
Copy link
Contributor

github-actions bot commented Jul 2, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 085c247 (parent) -> f51c987 (this PR)

Test differences

Show 7590 test diffs

7590 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f51c9870bab634afb9e7a262b6ca7816bb9e940d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. armhf-gnu: 4853.0s -> 5637.1s (16.2%)
  2. dist-x86_64-apple: 8389.3s -> 9361.3s (11.6%)
  3. x86_64-apple-1: 8477.0s -> 9434.0s (11.3%)
  4. dist-ohos-x86_64: 4184.9s -> 4597.3s (9.9%)
  5. dist-ohos-aarch64: 4628.4s -> 4199.4s (-9.3%)
  6. dist-x86_64-freebsd: 4523.2s -> 4909.5s (8.5%)
  7. arm-android: 5889.9s -> 6338.5s (7.6%)
  8. x86_64-apple-2: 5238.3s -> 4898.7s (-6.5%)
  9. dist-aarch64-msvc: 8669.6s -> 8121.2s (-6.3%)
  10. dist-x86_64-solaris: 4960.6s -> 5267.4s (6.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f51c987): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.3%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.3% [2.1%, 2.4%] 2
Regressions ❌
(secondary)
3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.3% [2.1%, 2.4%] 2

Cycles

Results (primary -1.1%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.3% [1.0%, 1.7%] 2
Regressions ❌
(secondary)
2.0% [0.5%, 3.0%] 4
Improvements ✅
(primary)
-2.2% [-2.4%, -2.2%] 4
Improvements ✅
(secondary)
-7.9% [-8.2%, -7.2%] 4
All ❌✅ (primary) -1.1% [-2.4%, 1.7%] 6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 462.05s -> 462.08s (0.01%)
Artifact size: 372.27 MiB -> 372.26 MiB (-0.00%)

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 11, 2025
Update stage0 to 1.89.0-beta.1

- Update version placeholders
- Update stage0 to 1.89.0-beta.1
- Update `STAGE0_MISSING_TARGETS`
- Update `cfg(bootstrap)`

r? `@Mark-Simulacrum`

try-job: dist-i586-gnu-i586-i686-musl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-android Operating system: Android O-linux Operating system: Linux S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants